Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_sesv2_email_identity_feedback_attributes: use the correct attribute as the resource ID in error messages #27784

Merged
merged 2 commits into from
Nov 14, 2022
Merged

r/aws_sesv2_email_identity_feedback_attributes: use the correct attribute as the resource ID in error messages #27784

merged 2 commits into from
Nov 14, 2022

Conversation

kamilturek
Copy link
Collaborator

Description

This PR fixes the wrong attribute used in the error messages when creating the aws_sesv2_feedback_attributes.

Relations

Relates #26796.

Output from Acceptance Testing

$ make testacc TESTARGS='-run=TestAccSESV2EmailIdentityFeedbackAttributes' PKG=sesv2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sesv2/... -v -count 1 -parallel 2  -run=TestAccSESV2EmailIdentityFeedbackAttributes -timeout 180m
=== RUN   TestAccSESV2EmailIdentityFeedbackAttributes_basic
=== PAUSE TestAccSESV2EmailIdentityFeedbackAttributes_basic
=== RUN   TestAccSESV2EmailIdentityFeedbackAttributes_disappears
=== PAUSE TestAccSESV2EmailIdentityFeedbackAttributes_disappears
=== RUN   TestAccSESV2EmailIdentityFeedbackAttributes_disappears_emailIdentity
=== PAUSE TestAccSESV2EmailIdentityFeedbackAttributes_disappears_emailIdentity
=== RUN   TestAccSESV2EmailIdentityFeedbackAttributes_emailForwardingEnabled
=== PAUSE TestAccSESV2EmailIdentityFeedbackAttributes_emailForwardingEnabled
=== CONT  TestAccSESV2EmailIdentityFeedbackAttributes_basic
=== CONT  TestAccSESV2EmailIdentityFeedbackAttributes_disappears_emailIdentity
--- PASS: TestAccSESV2EmailIdentityFeedbackAttributes_disappears_emailIdentity (21.27s)
=== CONT  TestAccSESV2EmailIdentityFeedbackAttributes_emailForwardingEnabled
--- PASS: TestAccSESV2EmailIdentityFeedbackAttributes_basic (28.49s)
=== CONT  TestAccSESV2EmailIdentityFeedbackAttributes_disappears
--- PASS: TestAccSESV2EmailIdentityFeedbackAttributes_disappears (22.52s)
--- PASS: TestAccSESV2EmailIdentityFeedbackAttributes_emailForwardingEnabled (44.74s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sesv2      67.833s

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. service/sesv2 Issues and PRs that pertain to the sesv2 service. needs-triage Waiting for first response or review from a maintainer. labels Nov 13, 2022
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@kamilturek kamilturek marked this pull request as ready for review November 14, 2022 08:02
@johnsonaj johnsonaj removed the needs-triage Waiting for first response or review from a maintainer. label Nov 14, 2022
@jar-b jar-b self-assigned this Nov 14, 2022
@jar-b jar-b added the bug Addresses a defect in current functionality. label Nov 14, 2022
jar-b
jar-b approved these changes Nov 14, 2022
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

$ make testacc PKG=sesv2 TESTS=TestAccSESV2EmailIdentityFeedbackAttributes
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sesv2/... -v -count 1 -parallel 20 -run='TestAccSESV2EmailIdentityFeedbackAttributes'  -timeout 180m
=== RUN   TestAccSESV2EmailIdentityFeedbackAttributes_basic
=== PAUSE TestAccSESV2EmailIdentityFeedbackAttributes_basic
=== RUN   TestAccSESV2EmailIdentityFeedbackAttributes_disappears
=== PAUSE TestAccSESV2EmailIdentityFeedbackAttributes_disappears
=== RUN   TestAccSESV2EmailIdentityFeedbackAttributes_disappears_emailIdentity
=== PAUSE TestAccSESV2EmailIdentityFeedbackAttributes_disappears_emailIdentity
=== RUN   TestAccSESV2EmailIdentityFeedbackAttributes_emailForwardingEnabled
=== PAUSE TestAccSESV2EmailIdentityFeedbackAttributes_emailForwardingEnabled
=== CONT  TestAccSESV2EmailIdentityFeedbackAttributes_basic
=== CONT  TestAccSESV2EmailIdentityFeedbackAttributes_disappears_emailIdentity
=== CONT  TestAccSESV2EmailIdentityFeedbackAttributes_disappears
=== CONT  TestAccSESV2EmailIdentityFeedbackAttributes_emailForwardingEnabled
--- PASS: TestAccSESV2EmailIdentityFeedbackAttributes_disappears_emailIdentity (15.69s)
--- PASS: TestAccSESV2EmailIdentityFeedbackAttributes_disappears (17.14s)
--- PASS: TestAccSESV2EmailIdentityFeedbackAttributes_basic (21.84s)
--- PASS: TestAccSESV2EmailIdentityFeedbackAttributes_emailForwardingEnabled (31.55s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sesv2      34.341s

@jar-b jar-b merged commit 5e23747 into hashicorp:main Nov 14, 2022
@jar-b
Copy link
Member

jar-b commented Nov 14, 2022

Nice find @kamilturek! 👍

@github-actions github-actions bot added this to the v4.40.0 milestone Nov 14, 2022
@kamilturek kamilturek deleted the b-aws-sesv2-email-identity-feedback-attributes-resource-id branch November 14, 2022 20:30
@github-actions
Copy link

This functionality has been released in v4.40.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jar-b jar-b jar-b approved these changes

Assignees

@jar-b jar-b

Labels
bug Addresses a defect in current functionality. service/sesv2 Issues and PRs that pertain to the sesv2 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v4.40.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kamilturek @jar-b @johnsonaj